Remove CI-only flags from public script and docs#36
Open
DASimp wants to merge 1 commit into
Open
Conversation
The --testing and --validate-os-only flags are intended for internal CI/Jenkins use only. Keeping them in the public repo exposes testing infrastructure details and creates a surface for malicious contributions. These flags remain in setup-scripts-dev. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-t|--testingflag (used internally to target the testing release URL)--validate-os-onlyflag (used by Jenkins to verify OS support without installing)VALIDATE_ONLYguards fromsetup()andvalidate_os_and_version()updates.simplerisk.com(no more testing URL toggle)README.mdto remove both CI-only flags from the help sectionWhy
These flags are for internal CI/Jenkins use only. Exposing them in the public repo creates a surface for malicious external contributions that could affect our testing infrastructure. Both flags remain fully intact in
setup-scripts-dev.Test plan
simplerisk-setup.sh --helpno longer shows--testingor--validate-os-onlyVALIDATE_ONLYregressions)updates.simplerisk.comresolves correctly for production installs🤖 Generated with Claude Code